Posts by bitfade

2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

The only official response from Envato was “we’ll consider this in the future” by Stephen. Quite frankly, i don’t why we’re forced to use TGMPA.

2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

Oh, please provide the js code, by all means ! :)
it’s included in the repository already
2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

+1 but is it going to offer regular future updates like TGM? That’s the question.
Class is gonna be used in our themes as well so yes.
2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

We’re a little stretched right now (responding to the add_query_arg vulnerability issue), so we need to ask people to stick with their current solutions for the moment – but it’s something we can consider in future
I’m not suggesting authors who are using TGMPA class to immediately switch to a different solution but, after the add_query_args sh**storm is gone, they should be free to

For instance, we are in the process of releasing a new theme (not before may) and would like to use the proposed solution.

As the TGMPA author said himself, most hooks were not available when the the project started in 2011 but they are now and since WordPress already includes plugins/themes install/update features, why not just taking advantage of them ?

A solution which reduces custom code while allowing buyers to use the same wp native interface they’re used to for wp.org plugins at the same time should be favoured by Envato rather than forbidden.

My 2c

edit: for those who asked, i included the js code in the github repo.
2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

@bitfade

If you add something like this http://snippi.com/s/dq8xhcy it will clearly demonstrate that you allow it’s usage.

Thank you.
Ah, ok. I thought there was some github setting involved. Just released under WTFPL license
2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

I believe your solution is much simpler and easy to maintain. Any chance you can set license on github if you allow other authors to use it?
I dont use github that much, i would i do that ?
2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

@Gamajo
A while ago there was a discussion here about theme bundled plugins, i kinda felt like using your class would be the only permitted way to handle them but couldn’t get an official answer.

To hook into the wp upgrade system is an alternate approach (much simpler imho) and author on TF should be allowed to take advantage of it. That’s the only reason of this thread.

2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

@bitfade, have you tested this with WP 4.2? Seems they’ve changed some of the plugin install screens, though unsure if this has any effect here really.
yep, i just tested with 4.2

we use it via ajax (example video) and can provide the js code if anybody interested
2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

This is nice class but it looks like it doesn’t support theme bundled plugins and update ?
doh, it seems that i forgot to push the latest version to github. Just did
2048 posts
  • Has referred 50+ members
  • Has sold $750,000+ on Envato Market
  • Has collected 10+ items on Envato Market
  • Elite Author: Sold more than $75,000 on Envato Market
+8 more
bitfade
says

This is nice class but it looks like it doesn’t support theme bundled plugins and update ?
That’s exactly what the class does, here’s a screenshot

by
by
by
by
by
by