Posts by billyf

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

I think it looks much better than many of the hard rejected themes here but the theme feels ‘empty’. Probably it’s because of the way you organized it, it feels as though there is nothing much unless I use the dropdown menu to navigate around (even so, some other pages are nothing but a few large images + some text).

Perhaps it’s better to make it look more like conventional themes but have another page / section showing this concept. The 2-column footer widget looks weird too, I think you should make it at least 3-4 columns. Good luck!

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

Yes, you can use MIT licensed scripts in your item. Here’s a list of open source licenses which you can use, although they do have some minor differences among different licenses.

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

The logo is horrible, to be honest. The hero image text should also be aligned centre vertically but the bigger issue lies with legibility. That orange is not really legible when used on that background image and the hover state of the navigation menu items are even more illegible.

The shadow upon hovering the items under ‘About Us’ also looks bad. It would be better without it or use very subtle shadow if you want. The same applies to all shadow effects on hover.

The arrows for Portfolio items are not vertically aligned in the middle too, aside from the badly-stretched images (you should crop them to proper aspect ratio). The portfolio items are quite ‘useless’ without links or lightbox pop-up.

Overall I think it’s a mediocre design with plenty of issues.

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

If you drew the background by yourself without using anything (e.g. brushes, patterns etc.) from others, they are your own work and you own the rights to it. You set the license for those background images which you drew.

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

What mean Non-Exclusive? how much I earn from per $21 sell if my item is Non-Exclusive? How to Become exclusive author?

Please refer to this page. You’ll get $7.56 for your $21 item if you’re selling as non-exclusive author.

If you have questions about being an author here, you can check out the help centre or contact Envato support if you have more questions which aren’t covered there.

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

Yes, “use strict” mode is mandatory, please check the submission requirements.

As for .on(), I think it’s quite straight forward. Just convert code like this :
$("#playVid").click(function(){
To something like this (also found in your file but further down) :
$('.control-btn').on("click",function() {
507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

Just out of interest what function would you use to escape $description? esc_html_e?

In the example above, I don’t think it’s really necessary but to escape text output, I think what you said will do.


hi,

@billyf : The reviewers won’t soft reject an item based on your example. From what i know, only esc_js and esc_attr are mandatory.

Best regards, Stefan

Thanks for the info but few months ago there was a thread about reviewer asking to escape everything, and a post by the reviewer telling authors to sanitize all output data (but there’s most likely exceptions to it depending on how it’s coded). So I think it’s best to escape all output as late as possible when needed.

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

I guess those are probably not mandatory or too difficult to check reliably. Just take esc_url / esc_attr for example, I don’t think Theme Check can automatically tell when to use which, and whether they are necessary at all.

Below is the code snippet taken from header.php from twentyfifteen theme :
$description = get_bloginfo( 'description', 'display' );
if ( $description || is_customize_preview() ) : ?>
    <p class="site-description"><?php echo $description; ?></p>
<?php endif;

ThemeForest reviewers would probably have soft-rejected an item with that code if they found ‘echo $’ because it’s not escaped (although get_bloginfo would have done the validation but it’s not the ‘last step’ in this case), but the WordPress developer team accepts it and is letting millions of user use it as the default theme.

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

I don’t see any problems with it if it’s a background pattern which repeats seamlessly. If it looks ‘tiled’, then you shouldn’t use that image.

507 posts
  • Has been part of the Envato Community for over 3 years
  • Has sold $40,000+ on Envato Market
  • Has referred 1+ members
  • Sells items exclusively on Envato Market
+1 more
billyf
says

thanks for your response. but how to check license for theme converted, if customer buy a theme, how to they can know “have been allowed to use that design or not?”

Which is why you can ask the author to confirm. If you see it being promoted at the other platform’s item page, it’s almost a guarantee that permission was given. If it has been around here for a while, it’s also very likely that an agreement has been made made between them. Otherwise someone would have reported it.

In short, just buy anything you like here without worrying too much, especially if the item is produced by reliable authors (those who have sold many items / have high ratings / here for a long time).

by
by
by
by
by
by