Posts by Smartik

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says

NO!

This does not allow elements to be inline.
The clear property specifies which side(s) of an element other floating elements are not allowed.
I made an example to understand better: http://jsfiddle.net/ge61y13r/

If you remove the * selector from code, elements are inline else the are each in a new line.

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says

Maybe the TF contact form does not work again and he does not receive the emails? This could be another reason…

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says

tonight I am thinking to try Godaddy auctions

Goddady auctions is dead. :D

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says


Look at my flag badge…
Ohh you have a new Melon Slice Badge!!!

And you have two :D one green and one red. ;)

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says

The color #555 is very bad for general general body text. Keep in mind that not all user has HD monitors or retina devices.

Change it to #333 or #222, please.

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says

I’m sure that a very small number of WP theme developers sanitize the data properly. The one that do it, is because they just want to be everything set up and to avoid possible future issues. Other just test it, and if it works, they move on.

For example I’ve seen similar functions not only once:
function block_title( $default = '' ){
    return ( !empty( get_option('pfx_title') ) ) ? get_option('pfx_title')  : $default;
}

Here are two problems. The value from DB and the default value are not sanitized. It may be OK if they are sanitized later, but if not then here is a problem.

If I echo it so:
$title = block_title('Default title');
echo sanitize_text_field($title);
Then it is perfectly fine, but sanitize_text_field may not be required if it is saved as needed in DB.

The most important is to sanitize the data entered by user before saving it to DB. Then you may be sure that you get the right value and even if you forget to escape a variable, that’s not a big problem because you know, your data is validated first.

$value = sanitize_text_field( $value );
update_option( 'pfx_title', $value );

A proper sanitization before saving it to DB is extremely important. If this is not done then the theme should be hard-rejected.

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says
In most cases this just does not makes sense. Example:
$output = '<tr>';
    $output .= '<th><label>'. sanitize_text_field( $settings['title'] ) .'</label></th>';
        $output .= '<td>';
            $output .= $this->show( $id, $settings, $saved_value );
        $output .= '</td>';
$output .= '</tr>';

echo $output;

`echo $output;` is totally safe and does not needs to be escaped. I would say that is imposible.

What I want to say is that if you have this type of data in many places, using the search pattern `echo $` will return all of them, but none needs attention.

Another case:
echo ( get_option('my_key') ) ? sanitize_text_field( get_option('my_key') ) : 'Default value';
Something like this needs sanitization, but it is very hard to find it. If I will not use `sanitize_text_field`, do you think somebody will notice it?
1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says
http://themeforest.net/make_money/become_an_author#calculator

Get the total sales($) value from “Earnings” page. Follow the link. Drag the slider to the number that is equal or greater than the value from “Earnings” page and there you’ll dee the pergentage that you get.

Here is the example. $62 == 62%

With total cumulative sales of $47,000 your Net Author Earning on a $100 item would be $62.
1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says

Excelent work. The most important part to come in is the quantity. :)
Also I think that the “Add to cart” button should be added on results page as well. This is useful on Photodune because once I see the image I would like to add it imediatelly to cart without the need to go to item page and click that button then again back to search/category results.

1286 posts
  • Has been part of the Envato Community for over 4 years
  • Has sold $40,000+ on Envato Market
  • Has been a beta tester for an Envato feature
  • Has collected 50+ items on Envato Market
+5 more
Smartik says

Banning bundled plugins will still not help the small theme producers get to the bestselling list. In fact it will make it harder. Whereas now, when the big theme production houses create their own sliders and page builders etc. small authors can compete by bundling cc plug-ins. If you ban bundled plugins, the big players will still include there own. What are you going to do then. Ban any sliders or page builders etc?
I always think that good WP developers should be able to create everything they need without 3rd party code. If you can create your own plugin, then include it with the theme, if not, just add the support for a plugin that you like. So you are not responsible for that plugin, you just have to make sure it works properly with your theme. A good example id WPML, and that’s how it should be for other premium plugins, here should not be an exception.


“Small authors” as you say, don’t even know how WP works and include all these premium plugin as a feature not as a bonus. That’s not right. This look more like a deal, “buy my theme and your get 100$ worth of premium plugins”. Where we go? In order to sell a theme for 50$ we must include 100$ for free?

by
by
by
by
by
by